[PATCH] D75987: [mlir][AVX512] Start a primitive AVX512 dialect

[Nicolas Vasilache via Phabricator via llvm-commits]

nicolasvasilache added inline comments.


================
Comment at: mlir/lib/Conversion/AVX512ToLLVM/ConvertAVX512ToLLVM.cpp:36
+template <typename SourceOp, typename TargetOp>
+PatternMatchResult matchAndRewriteOneToOne(
+    const ConvertToLLVMPattern &lowering, LLVMTypeConverter &typeConverter,
----------------
rriddle wrote:
> Note that a few things have changed at head:
> 
> PatternMatchResult -> LogicalResult
> matchSuccess -> success
> matchFailure -> failure
Rebased.


================
Comment at: mlir/lib/Target/LLVMIR/AVX512Intr.cpp:30
+  LogicalResult convertOperation(Operation &opInst,
+                                 llvm::IRBuilder<> &builder) override {
+#include "mlir/Dialect/AVX512/AVX512Conversions.inc"
----------------
rriddle wrote:
> Not sure if this is possible yet, but we should really remove the need to use inheritance for extension.
I don't see any CRTP on ModuleTranslation yet, can we keep this as an NFC followup refactor?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75987/new/

https://reviews.llvm.org/D75987