[PATCH] D75579: Replace MCTargetOptionsCommandFlags.inc and CommandFlags.inc by runtime-registration

Tue Mar 17 20:00:02 PDT 2020

modocache added a comment.

I may be wrong, but I believe this breaks `check-llvm` when run with the following configuration: `cmake -DLLVM_BINUTILS_INCDIR=/path/to/binutils/include`:

  Failing Tests (6):
      LLVM :: tools/gold/X86/common_thinlto.ll
      LLVM :: tools/gold/X86/emit-llvm.ll
      LLVM :: tools/gold/X86/pr25907.ll
      LLVM :: tools/gold/X86/relax-relocs.ll
      LLVM :: tools/gold/X86/relocation-model-pic.ll
      LLVM :: tools/gold/X86/strip_names.ll

When bisecting for those specific test failures, I found this commit. The issue, I believe, is with how those tests pass options to the LLVMgold plugin. For what it's worth, my binutils reports version 2.27.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75579/new/

https://reviews.llvm.org/D75579