[PATCH] D76321: [mlir] Add target for Shape dialect

[Jacques Pienaar via Phabricator via llvm-commits]

jpienaar marked 4 inline comments as done.
jpienaar added a comment.

Updated, thanks



================
Comment at: mlir/lib/Dialect/Shape/IR/Shape.cpp:26-27
+  addTypes<ComponentType, ElementType, ShapeType, SizeType, ValueShapeType>();
+  // Allow unknown operations during testing.
+  allowUnknownOperations();
+}
----------------
silvas wrote:
> Can we remove this? Just use "foo.op" instead of "shape.op" during testing?
Expanded the comment to mention it is also for prototyping while the dialect is still changing a lot.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76321/new/

https://reviews.llvm.org/D76321