[PATCH] D76242: [mlir][spirv] Plumbing target environment into type converter

[Mahesh Ravishankar via Phabricator via llvm-commits]

mravishankar accepted this revision.
mravishankar added inline comments.
This revision is now accepted and ready to land.


================
Comment at: mlir/include/mlir/Dialect/SPIRV/TargetAndABI.h:54
+  TargetEnvAttr targetAttr;
+  llvm::SmallSet<Extension, 4> givenExtensions;    /// Allowed extensions
+  llvm::SmallSet<Capability, 8> givenCapabilities; /// Allowed capabilities
----------------
antiagainst wrote:
> mravishankar wrote:
> > These might cause subtle issues later  on. Can we make this a SetVector?
> But what we want here is just a set. We don't care about the order. What problems do you think will have with SmallSet?
For now this is not iterated over. But there is no gaurantee later on and is easy to miss. Dont see too much advantage of using SmallSet vs SetVector, and just prefer to use the latter.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76242/new/

https://reviews.llvm.org/D76242