[PATCH] D76085: [DWARFLinker][dsymutil][NFC] add section index into address range.

Tue Mar 17 12:23:50 PDT 2020

avl added a comment.

> I'm not sure I understand the alternative - are you picturing doing the DWARF reduction and updating relocations and then feeding the reduced but unrelocated DWARF into lld's linking step?

yes. I planned to do in that way.

1. Do DWARF reduction. (Do not patch DWARF address values(LowPC, HighPC...) as dsymutil usually does, fix relocations in-sections offsets)
2. Go through usual linking process which would resolve relocations and put proper address values.

> The debug map seems like it should be the same data structure that would be used for applying relocations anyway - is it not? I'd be surprised if it was significantly different/new cost to have that data available for the DWARF linking as it would be for the relocation application.

I would check it more. If all necessary info could be produced from the single relocation(without preliminary gathering data and creating additional maps) then - yes, it is cheap.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76085/new/

https://reviews.llvm.org/D76085