[PATCH] D75865: Introduce unify-loop-exits pass.

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 17 10:11:01 PDT 2020


arsenm added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/UnifyLoopExits.cpp:174-191
+#if defined(EXPENSIVE_CHECKS)
+  assert(DT.verify(DominatorTree::VerificationLevel::Full));
+#else
+  assert(DT.verify(DominatorTree::VerificationLevel::Fast));
+#endif
+  L->verifyLoop();
+
----------------
Won't the verifier catch these after the pass anyway?

If not I think the all the verification calls should be moved to a separate function


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75865/new/

https://reviews.llvm.org/D75865





More information about the llvm-commits mailing list