[PATCH] D75703: Splits __wasm_apply_relocs into multiple functions
James Y Knight via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Mar 17 10:10:57 PDT 2020
jyknight added a comment.
Copying what I said from Discord --
If I were a reviewer on this, I'd say that's too much a hack, and that it would be a much better idea to implement the "TODO(sbc): Encode the relocations in the data section and write a loop here to apply them."
That would allow this function to be both constant and tiny.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75703/new/
https://reviews.llvm.org/D75703
More information about the llvm-commits
mailing list