[PATCH] D75863: [AIX] Implement by-val caller arguments in a single register

Chris Bowler via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 17 10:10:53 PDT 2020


cebowleratibm planned changes to this revision.
cebowleratibm marked 4 inline comments as done.
cebowleratibm added a comment.

-Add CC_AIX logic to pass over 0 size by-val arguments.
-Tidy the by val tests added.
-Some expected output changes required in aix-cc-byval.ll related to use of ZEXTLOAD now that I've added the run step.



================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:7163
+      SDValue RegVal;
+      for (unsigned Bytes = 0; Bytes != ByValSize;) {
+        unsigned N = PowerOf2Floor(ByValSize - Bytes);
----------------
ZarkoCA wrote:
> I'm curious as to what happens with 0 sized parameter, will they need special handling like they do on the callee side or do they need to be skipped? 
We should skip 0 size by-val arguments in CC_AIX and assert non-zero by-val size here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75863/new/

https://reviews.llvm.org/D75863





More information about the llvm-commits mailing list