[PATCH] D76139: [Target][ARM] Change VPTMaskValues to the correct encoding

Simon Tatham via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 17 08:31:33 PDT 2020


simon_tatham added inline comments.


================
Comment at: llvm/lib/Target/ARM/Utils/ARMBaseInfo.h:103
+  ///   Txyz = xyz1
   enum VPTMaskValue {
+    T = 0b1000,
----------------
Since these mask values are now encoded in the common format used by the MCOperand for both `VPT` and `IT` instructions, perhaps they should have a more generic name than `VPTMaskValue`, and live in the `ARM` namespace instead of `ARMVCC`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76139/new/

https://reviews.llvm.org/D76139





More information about the llvm-commits mailing list