[PATCH] D76241: [mlir][spirv] Use memref memory space for storage class
Uday Bondhugula via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Mar 17 07:57:54 PDT 2020
bondhugula requested changes to this revision.
bondhugula added inline comments.
This revision now requires changes to proceed.
================
Comment at: mlir/include/mlir/IR/Types.h:172
- /// Return true of this is an integer(of any signedness) or a float type.
+ /// Return true of this is an integer (of any signedness) or a float type.
bool isIntOrFloat();
----------------
Typo: of this -> if this
================
Comment at: mlir/include/mlir/IR/Types.h:174
bool isIntOrFloat();
+ /// Return true of this is an integer (of any signedness), index, or float
+ /// type.
----------------
of this -> if this
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76241/new/
https://reviews.llvm.org/D76241
More information about the llvm-commits
mailing list