[PATCH] D73086: [DWARF5] Added support for debug_macro section parsing and dumping in llvm-dwarfdump.

Tue Mar 17 06:18:06 PDT 2020

jhenderson added a comment.

In D73086#1926329 <https://reviews.llvm.org/D73086#1926329>, @SouraVX wrote:

> In D73086#1926229 <https://reviews.llvm.org/D73086#1926229>, @ikudrin wrote:
>
> > I am mostly OK with the changes at the moment. Please reach the consent with @jhenderson about code duplication and other topics he mentioned.
>
>
> Thanks for the consent @Ikudrin!
>  @jhenderson, Are you okay with these changes?

You said you'd take a look at removing the duplication. Have you done that yet? That's what I'm waiting on.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73086/new/

https://reviews.llvm.org/D73086