[PATCH] D75929: [DebugInfo] Support DWARFv5 index sections.

Igor Kudrin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 17 05:43:32 PDT 2020


ikudrin added inline comments.


================
Comment at: llvm/tools/llvm-dwp/llvm-dwp.cpp:614
+    if (CUIndex.getVersion() != 2)
+      return make_error<DWPError>("Unsupported cu_index version");
 
----------------
jhenderson wrote:
> jhenderson wrote:
> > I see the above error message starts with a capital letter, but more generally I think we try to use lower-case for error messages. Maybe worth doing it right here and changing the above line in a separate change?
> Ping?
Fixed. Sorry for forgetting those. D76277 is added for changing the existing messages.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75929/new/

https://reviews.llvm.org/D75929





More information about the llvm-commits mailing list