[PATCH] D76277: [llvm-dwp] Start error messages with lowercase letters.

[Igor Kudrin via Phabricator via llvm-commits]

ikudrin created this revision.
ikudrin added reviewers: jhenderson, dblaikie, probinson.
ikudrin added projects: LLVM, debug-info.
Herald added a subscriber: arphaman.

We usually start error messages with lowercase letters and most of them in `llvm-dwp` follow that rule. This patch fixes a few messages that started with capital letters.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D76277

Files:
  llvm/test/tools/llvm-dwp/X86/duplicate.test
  llvm/test/tools/llvm-dwp/X86/gcc_type.test
  llvm/test/tools/llvm-dwp/X86/invalid_cu_index.test
  llvm/test/tools/llvm-dwp/X86/missing_tu_index.test
  llvm/tools/llvm-dwp/llvm-dwp.cpp


Index: llvm/tools/llvm-dwp/llvm-dwp.cpp
===================================================================
--- llvm/tools/llvm-dwp/llvm-dwp.cpp
+++ llvm/tools/llvm-dwp/llvm-dwp.cpp
@@ -477,7 +477,7 @@
 buildDuplicateError(const std::pair<uint64_t, UnitIndexEntry> &PrevE,
                     const CompileUnitIdentifiers &ID, StringRef DWPName) {
   return make_error<DWPError>(
-      std::string("Duplicate DWO ID (") + utohexstr(PrevE.first) + ") in " +
+      std::string("duplicate DWO ID (") + utohexstr(PrevE.first) + ") in " +
       buildDWODescription(PrevE.second.Name, PrevE.second.DWPName,
                           PrevE.second.DWOName) +
       " and " + buildDWODescription(ID.Name, DWPName, ID.DWOName));
@@ -594,7 +594,7 @@
     DWARFUnitIndex CUIndex(DW_SECT_INFO);
     DataExtractor CUIndexData(CurCUIndexSection, Obj.isLittleEndian(), 0);
     if (!CUIndex.parse(CUIndexData))
-      return make_error<DWPError>("Failed to parse cu_index");
+      return make_error<DWPError>("failed to parse cu_index");
 
     for (const DWARFUnitIndex::Entry &E : CUIndex.getRows()) {
       auto *I = E.getOffsets();
@@ -629,7 +629,7 @@
       DWARFUnitIndex TUIndex(DW_SECT_TYPES);
       DataExtractor TUIndexData(CurTUIndexSection, Obj.isLittleEndian(), 0);
       if (!TUIndex.parse(TUIndexData))
-        return make_error<DWPError>("Failed to parse tu_index");
+        return make_error<DWPError>("failed to parse tu_index");
       addAllTypesFromDWP(Out, TypeIndexEntries, TUIndex, TypesSection,
                          CurTypesSection.front(), CurEntry,
                          ContributionOffsets[DW_SECT_TYPES - DW_SECT_INFO]);
Index: llvm/test/tools/llvm-dwp/X86/missing_tu_index.test
===================================================================
--- llvm/test/tools/llvm-dwp/X86/missing_tu_index.test
+++ llvm/test/tools/llvm-dwp/X86/missing_tu_index.test
@@ -1,3 +1,3 @@
 RUN: not llvm-dwp %p/../Inputs/missing_tu_index/x.dwp -o %t 2>&1 | FileCheck %s
 
-CHECK: error: Failed to parse tu_index
+CHECK: error: failed to parse tu_index
Index: llvm/test/tools/llvm-dwp/X86/invalid_cu_index.test
===================================================================
--- llvm/test/tools/llvm-dwp/X86/invalid_cu_index.test
+++ llvm/test/tools/llvm-dwp/X86/invalid_cu_index.test
@@ -1,3 +1,3 @@
 RUN: not llvm-dwp %p/../Inputs/invalid_cu_index/x.dwp -o %t 2>&1 | FileCheck %s
 
-CHECK: error: Failed to parse cu_index
+CHECK: error: failed to parse cu_index
Index: llvm/test/tools/llvm-dwp/X86/gcc_type.test
===================================================================
--- llvm/test/tools/llvm-dwp/X86/gcc_type.test
+++ llvm/test/tools/llvm-dwp/X86/gcc_type.test
@@ -5,4 +5,4 @@
 CHECK: Type Unit
 
 // Check that llvm-dwp can parse DW_FORM_string for CU name
-DUP: Duplicate DWO ID ({{.*}}) in 'a.cpp' and 'a.cpp'
+DUP: duplicate DWO ID ({{.*}}) in 'a.cpp' and 'a.cpp'
Index: llvm/test/tools/llvm-dwp/X86/duplicate.test
===================================================================
--- llvm/test/tools/llvm-dwp/X86/duplicate.test
+++ llvm/test/tools/llvm-dwp/X86/duplicate.test
@@ -18,10 +18,10 @@
 
 Build from a, b, and c.c all containing a single void() func by the name of the file.
 
-DWOS: error: Duplicate DWO ID ({{.*}}) in 'c.c' and 'c.c'{{$}}
-1DWP: error: Duplicate DWO ID ({{.*}}) in 'c.c' (from '{{.*}}ac.dwp') and 'c.c'{{$}}
-2DWP: error: Duplicate DWO ID ({{.*}}) in 'c.c' and 'c.c' (from '{{.*}}bc.dwp'){{$}}
+DWOS: error: duplicate DWO ID ({{.*}}) in 'c.c' and 'c.c'{{$}}
+1DWP: error: duplicate DWO ID ({{.*}}) in 'c.c' (from '{{.*}}ac.dwp') and 'c.c'{{$}}
+2DWP: error: duplicate DWO ID ({{.*}}) in 'c.c' and 'c.c' (from '{{.*}}bc.dwp'){{$}}
 
-DWODWOS: error: Duplicate DWO ID ({{.*}}) in 'c.c' and 'c.c'{{$}}
-DWO1DWP: error: Duplicate DWO ID ({{.*}}) in 'c.c' (from 'c.dwo' in '{{.*}}ac.dwp') and 'c.c'{{$}}
-DWO2DWP: error: Duplicate DWO ID ({{.*}}) in 'c.c' and 'c.c' (from 'c.dwo' in '{{.*}}bc.dwp'){{$}}
+DWODWOS: error: duplicate DWO ID ({{.*}}) in 'c.c' and 'c.c'{{$}}
+DWO1DWP: error: duplicate DWO ID ({{.*}}) in 'c.c' (from 'c.dwo' in '{{.*}}ac.dwp') and 'c.c'{{$}}
+DWO2DWP: error: duplicate DWO ID ({{.*}}) in 'c.c' and 'c.c' (from 'c.dwo' in '{{.*}}bc.dwp'){{$}}


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D76277.250724.patch
Type: text/x-patch
Size: 4239 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200317/07cc9b63/attachment.bin>