[PATCH] D76266: [mlir][Vector] Mostly-NFC - Restructure options for lowering to LLVM Matrix Intrinsics

[Aart Bik via Phabricator via llvm-commits]

aartbik added inline comments.


================
Comment at: mlir/include/mlir/Dialect/VectorOps/VectorOps.h:27
 
+struct VectorTransformsOptions {
+  bool lowerToLLVMMatrixIntrinsics = false;
----------------
add a comment here to document the struct

(options for the vector transforms, or at least the contract populate method for now)


================
Comment at: mlir/include/mlir/Dialect/VectorOps/VectorOps.h:28
+struct VectorTransformsOptions {
+  bool lowerToLLVMMatrixIntrinsics = false;
+};
----------------
provide convenience constructors for this

(one bool is simple but if we add more that may come in handy?)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76266/new/

https://reviews.llvm.org/D76266