[PATCH] D76254: [mlir] Add support for the attribute verifiers in the dialect declaration generator.

Lei Zhang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 16 18:03:28 PDT 2020


antiagainst accepted this revision.
antiagainst added inline comments.
This revision is now accepted and ready to land.


================
Comment at: mlir/include/mlir/Dialect/SPIRV/SPIRVBase.td:52
+  let hasRegionArgAttrVerify = 1;
+  let hasRegionResultAttrVerify = 1;
   let extraClassDeclaration = [{
----------------
Nit: can we use an empty line between these bits and the `extraClassDeclaration`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76254/new/

https://reviews.llvm.org/D76254





More information about the llvm-commits mailing list