[PATCH] D71027: Support repeated machine outlining
Jin Lin via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Mar 16 17:31:05 PDT 2020
jinlin added inline comments.
================
Comment at: llvm/lib/CodeGen/MachineOutliner.cpp:1513
+ report_fatal_error("Expect NumRepeat for machine outlining "
+ "is equal or greater than 1!\n");
+
----------------
paquette wrote:
> Grammar nit: "Expect NumRepeat for machine outlining to be greater than or equal to 1"
Done.
================
Comment at: llvm/test/CodeGen/AArch64/machine-outliner-iterative.mir:139-140
+# TWO-RUNS-NEXT: TCRETURNdi @OUTLINED_FUNCTION_0, 0, implicit $sp
+# FOUR-RUNS-NOT: [[OUTLINED:OUTLINED_FUNCTION_3_[0-9]+]]
+# FOUR-RUNS-NOT: [[OUTLINED:OUTLINED_FUNCTION_4_[0-9]+]]
----------------
paquette wrote:
> Can you add a comment explaining why these functions are not expected?
Done.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71027/new/
https://reviews.llvm.org/D71027
More information about the llvm-commits
mailing list