[PATCH] D75131: [XCOFF][AIX] Enable -r option for llvm-objdump

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast added inline comments.


================
Comment at: llvm/lib/BinaryFormat/XCOFF.cpp:36
+
+#define RELOC_CASE(A)                                                \
+  case XCOFF::A:                                                         \
----------------
This does not follow the convention of placing the backslash on the same column for all lines of a macro definition.


================
Comment at: llvm/lib/Object/XCOFFObjectFile.cpp:21
 
-enum { FUNCTION_SYM = 0x20, SYM_TYPE_MASK = 0x07, RELOC_OVERFLOW = 65535 };
+enum {
+  FUNCTION_SYM = 0x20,
----------------
This should be in an anonymous namespace if a drive-by fix is okay.


================
Comment at: llvm/lib/Object/XCOFFObjectFile.cpp:25
+  RELOC_OVERFLOW = 65535,
+  NO_REL_MASK = 0x0001
+};
----------------
The types associated with these constants do not appear to be uniform. It does not appear that these should be all enumerators of the same enumeration type.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75131/new/

https://reviews.llvm.org/D75131