[PATCH] D70720: [llvm-objdump] Display locations of variables alongside disassembly

[Hongtao Yu via Phabricator via llvm-commits]

hoyFB added inline comments.


================
Comment at: llvm/include/llvm/Support/FormattedStream.h:108
 
-  /// getColumn - Return the column number
-  unsigned getColumn() { return Position.first; }
+  unsigned getColumn() {
+    // Calculate current position, taking buffer contents into account.
----------------
Hello, looks like this change breaks the clang test: clang/test/Analysis/checker-plugins.c by changing the printing format 

from:
     example.MyChecker:ExampleOption                   (bool) This is an example checker opt. (default: false)
to:
     example.MyChecker:ExampleOption                   (bool) This is an example checker opt. (default:
                                                                                  false)
and the test fails at

     // CHECK-CHECKER-OPTION-HELP: example.MyChecker:ExampleOption  (bool) This is an
     // CHECK-CHECKER-OPTION-HELP-SAME: example checker opt. (default: false)

Can you please take a look? Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70720/new/

https://reviews.llvm.org/D70720