[PATCH] D76203: [mlir] Add a hook to PatternRewriter to allow for patterns to notify why a match failed.

[River Riddle via Phabricator via llvm-commits]

rriddle marked 2 inline comments as done.
rriddle added inline comments.


================
Comment at: mlir/lib/Transforms/DialectConversion.cpp:996
+  LLVM_DEBUG({
+    Diagnostic diag(op->getLoc(), DiagnosticSeverity::Error);
+    reasonCallback(diag);
----------------
jpienaar wrote:
> Is a match failing really an error?
Changed to Remark. Given that we don't include the severity in the message here, it doesn't matter what it gets set to.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76203/new/

https://reviews.llvm.org/D76203