[PATCH] D75845: [ValueLattice] Add singlecrfromundef lattice value.

[Eli Friedman via Phabricator via llvm-commits]

efriedma added inline comments.


================
Comment at: llvm/include/llvm/Analysis/ValueLattice.h:44
+    /// Transition allowed to the following states:
+    ///  constant
+    ///  singlecrfromundef
----------------
fhahn wrote:
> efriedma wrote:
> > Is there actually a transition from undef -> constant?
> Yes it is allowed in `mergeIn()`, which also ensures going to overdefined if we merge a constant with a different constant.
Oh, I see.  It's probably worth calling out in the documentation for constant: it might actually come from an undef/constant merge, like singlecrfromundef.  (I don't think it has any practical impact at the moment, but it could matter in the future.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75845/new/

https://reviews.llvm.org/D75845