[PATCH] D76241: [mlir][spirv] Use memref memory space for storage class

[River Riddle via Phabricator via llvm-commits]

rriddle added inline comments.


================
Comment at: mlir/lib/Dialect/SPIRV/SPIRVDialect.cpp:870
 
-// Verifies the given SPIR-V `attribute` attached to a region's argument or
-// result and reports error to the given location if invalid.
-static LogicalResult
-verifyRegionAttribute(Location loc, NamedAttribute attribute, bool forArg) {
+// Verifies the given SPIR-V `attribute` attached to a value of the given
+// `valueType` is valid.
----------------
nit: ///


================
Comment at: mlir/lib/Dialect/SPIRV/SPIRVLowering.cpp:41
 
+// Mapping between SPIR-V storage classes to memref memory spaces.
+//
----------------
nit: ///


================
Comment at: mlir/lib/Dialect/SPIRV/TargetAndABI.cpp:15
 #include "mlir/IR/SymbolTable.h"
+#include "mlir/Support/LLVM.h"
 
----------------
Is this not included transitively already?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76241/new/

https://reviews.llvm.org/D76241