[PATCH] D76243: [mlir][spirv] Move type checks from dialect class to type hierarchy

[Lei Zhang via Phabricator via llvm-commits]

antiagainst created this revision.
antiagainst added a reviewer: denis13.
Herald added subscribers: llvm-commits, bader, Joonsoo, liufengdb, aartbik, lucyrfox, mgester, arpith-jacob, nicolasvasilache, shauheen, burmako, jpienaar, rriddle, mehdi_amini.
Herald added a reviewer: mravishankar.
Herald added a project: LLVM.
antiagainst added a child revision: D76244: [mlir][spirv] Make SPIRVTypeConverter target environment aware.

Types should be checked with the type hierarchy. This should result in
better responsibility division and API surface.

Depends On D76242 <https://reviews.llvm.org/D76242>


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D76243

Files:
  mlir/include/mlir/Dialect/SPIRV/SPIRVDialect.h
  mlir/include/mlir/Dialect/SPIRV/SPIRVTypes.h
  mlir/lib/Dialect/SPIRV/LayoutUtils.cpp
  mlir/lib/Dialect/SPIRV/SPIRVCanonicalization.cpp
  mlir/lib/Dialect/SPIRV/SPIRVDialect.cpp
  mlir/lib/Dialect/SPIRV/SPIRVLowering.cpp
  mlir/lib/Dialect/SPIRV/SPIRVOps.cpp
  mlir/lib/Dialect/SPIRV/SPIRVTypes.cpp
  mlir/lib/Dialect/SPIRV/Transforms/LowerABIAttributesPass.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D76243.250607.patch
Type: text/x-patch
Size: 12498 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200316/b46d5b1b/attachment-0001.bin>