[PATCH] D75892: [InstSimplify][SVE] Fix SimplifyGEPInst for scalable vector.

Huihui Zhang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 16 12:01:29 PDT 2020


huihuiz marked an inline comment as done.
huihuiz added inline comments.


================
Comment at: llvm/lib/Analysis/InstructionSimplify.cpp:4085
+  bool IsScalableVec =
+      SrcTy->isVectorTy() ? SrcTy->getVectorIsScalable() : false;
+
----------------
efriedma wrote:
> We should probably consider adding an API to Type to check whether the size of a type is a compile-time constant, so we don't repeat `SrcTy->isVectorTy() ? SrcTy->getVectorIsScalable() : false` all over the place.  I guess that doesn't have to happen here, though.
Thanks Eli for the feedback! I will post a patch for this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75892/new/

https://reviews.llvm.org/D75892





More information about the llvm-commits mailing list