[PATCH] D76227: [obj2yaml] - SHT_DYNAMIC and SHT_REL* sections: stop dumping sh_entsize field when it has the default value.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.

Quote the ELF spec.

> Some sections hold a table of fixed-size entries, such as a symbol table. For such a section, this member gives the size in bytes of each entry. The member contains 0 if the section does not hold a table of fixed-size entries.

For SHT_DYNAMIC and SHT_REL*, I think omitting sh_entsize is fine because they can be followed by entries. The following entries make it clear that they are tables of fixed-size entries.

If they could't be followed by entries, I would be nervous as this change added hidden knowledge.

Please hold off and wait for @jhenderson


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76227/new/

https://reviews.llvm.org/D76227