[PATCH] D76239: [X86] X86CallFrameOptimization - generalize slow push code path

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon created this revision.
RKSimon added reviewers: craig.topper, spatel.
Herald added subscribers: jfb, hiraditya.
Herald added a project: LLVM.

Replace the explicit isAtom() || isSLM() test with the more general (and more specific) slowTwoMemOps() check to avoid the use of the PUSHrmm push from memory case.

This is actually very tricky to test in anything but quite complex code, but the atomic-idempotent.ll tests seem to be the most straightforward to use. If people are happy with me using these tests I can add the extra target checks as a pre-commit.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D76239

Files:
  llvm/lib/Target/X86/X86CallFrameOptimization.cpp
  llvm/test/CodeGen/X86/atomic-idempotent.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D76239.250596.patch
Type: text/x-patch
Size: 20719 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200316/5d7cd4c5/attachment.bin>