[PATCH] D76145: [DebugInfo] Introduce a DW_OP_LLVM_convert_generic operation

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 16 10:20:27 PDT 2020


aprantl added a comment.

Have you thought about doing this



================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfExpression.cpp:502
+        emitOp(dwarf::DW_OP_convert);
+        emitUnsigned(0); // ULEB128.
+      }
----------------
djtodoro wrote:
> `//<`comment instead?
I don't think that's a thing for non-doxygen comments.

The proper, if verbose, LLVM style is

```
/ ULEB128.
emitUnsigned(0);
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76145/new/

https://reviews.llvm.org/D76145





More information about the llvm-commits mailing list