[PATCH] D73086: [DWARF5] Added support for debug_macro section parsing and dumping in llvm-dwarfdump.

[Sourabh Singh Tomar via Phabricator via llvm-commits]

SouraVX added inline comments.


================
Comment at: llvm/test/DebugInfo/X86/debug-macro-macinfo.s:42
+	.byte	1                       # File Number
+	.ascii	"DWARF_VERSION"        # Macro String
+	.byte	32                      # Space
----------------
ikudrin wrote:
> You may just use `.asciz "DWARF_VERSION 4"`. It is the same. The fact that the macro string consists of the name, space, and value is not important for this test. And you have not divided the definition for "DWARF_VERSION 5" despite it follows the same rules.
>  And you have not divided the definition for "DWARF_VERSION 5" despite it follows the same rules.
Are you concerned regarding representation ?? 
DW_MACRO_define_strp forms requires the entire macro and definition(value) "DWARF_VERSION 5" to be kept as a string in debug_str section. 
That's what I've done here. Am I missing something here ?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73086/new/

https://reviews.llvm.org/D73086