[PATCH] D76232: [AMDGPU] Fix whole wavefront mode
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Mar 16 09:48:04 PDT 2020
arsenm added inline comments.
================
Comment at: llvm/lib/Target/AMDGPU/SIWholeQuadMode.cpp:538
// Skip instructions that are not affected by EXEC
if (TII->isScalarUnit(MI))
----------------
Can't this whole function be replaced with SIInstrInfo::mayReadExec?
================
Comment at: llvm/test/CodeGen/AMDGPU/wqm.mir:119-147
+name: copy_exec
+alignment: 1
+exposesReturnsTwice: false
+legalized: false
+regBankSelected: false
+selected: false
+failedISel: false
----------------
Should be able to remove all of this (except tracksRegLiveness: true)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76232/new/
https://reviews.llvm.org/D76232
More information about the llvm-commits
mailing list