[PATCH] D75095: [MC][ARM] Don't create multiple .ARM.exidx associated to one .text

Mon Mar 16 09:48:03 PDT 2020

MaskRay added a comment.

In D75095#1923866 <https://reviews.llvm.org/D75095#1923866>, @maxim-kuvyrkov wrote:

> Hi @MaskRay ,
>
> Quite surprisingly, this patch increases code size by 3-4% on several SPEC CPU2006 benchmarks for arm-linux-gnueabihf at -Oz optimization level:
>
> 1. 473.astar,astar_base.default                                  regressed by 103
> 2. 450.soplex,soplex_base.default                                regressed by 103
> 3. 483.xalancbmk,Xalan_base.default                              regressed by 104
>
>   With -Os I see 2-3% code size increase for same benchmarks:
> 4. 473.astar,astar_base.default                                  regressed by 102
> 5. 450.soplex,soplex_base.default                                regressed by 102
> 6. 483.xalancbmk,Xalan_base.default                              regressed by 103
>
>   Would you please check if the code size increase expected for this patch?
>
>   Let me know if you need help reproducing the issue.  Thanks!

@maxim-kuvyrkov D75095 <https://reviews.llvm.org/D75095> fixed a misuse and could be applied before D74006 <https://reviews.llvm.org/D74006>. I can't think of how it could increase code size.

Echo the comment from https://reviews.llvm.org/D74006#1920702 
Could you try to figure out what's actually different about the object files/executables before/after this patch, using objdump and readelf -S?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75095/new/

https://reviews.llvm.org/D75095