[PATCH] D76170: [OpenMP][NFC] Reduce instantiation time with different data structure

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 16 09:14:48 PDT 2020


rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm, as long as you are OK with the casts as the code author.



================
Comment at: llvm/lib/Frontend/OpenMP/OMPContext.cpp:130-132
+  for (const auto &SetBitsIt : VMI0.RequiredTraits.set_bits())
+    if (!VMI1.RequiredTraits.test(SetBitsIt))
+      return false;
----------------
I expected BitVector to expose an API to do this without iterating the bits individually, but I can't find one. `test` seems close, but not quite right. Oh well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76170/new/

https://reviews.llvm.org/D76170





More information about the llvm-commits mailing list