[PATCH] D75994: [GlobalISel] add additional lowering support for G_INSERT

[Dominik Montada via Phabricator via llvm-commits]

gargaroff closed this revision.
gargaroff marked an inline comment as done.
gargaroff added a comment.

8ff2dcb18b559f0a5825c79e66d6ec0d106e5a90 <https://reviews.llvm.org/rG8ff2dcb18b559f0a5825c79e66d6ec0d106e5a90>



================
Comment at: llvm/test/CodeGen/AMDGPU/GlobalISel/legalize-insert.mir:1298
     ; CHECK: [[OR:%[0-9]+]]:_(s32) = G_OR [[AND1]], [[AND]]
-    ; CHECK: [[BITCAST:%[0-9]+]]:_(s32) = G_BITCAST [[OR]](s32)
-    ; CHECK: $vgpr0 = COPY [[BITCAST]](s32)
----------------
arsenm wrote:
> Should this have been triggering a verifier error? Is there a missing check for source type == dest type?
I guess so. I'd say that casting only makes sense when the types change. Might be worth to look into in a follow up.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75994/new/

https://reviews.llvm.org/D75994