[PATCH] D76230: [AMDGPU] Enable SEXT divergence driven selection.
Alexander via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Mar 16 08:08:13 PDT 2020
alex-t added a comment.
In D76230#1924449 <https://reviews.llvm.org/D76230#1924449>, @arsenm wrote:
> Test name is misleading, this should just go in the realgar sext test. Also I would expect this to already be well covered
This is not covered at all. Most of the tests except those I have already updated assume that we select everything to scalars and rely on the latest SIFixSGPRCopies moveToVALU.
Also, I would prefer to have the tests checking divergence driven ISel separately until we remove moveToVALU path completely. Otherwise I always should expect someone accidentally removing selection predicates that generates no errors but silently go through the moveToVALU.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76230/new/
https://reviews.llvm.org/D76230
More information about the llvm-commits
mailing list