[PATCH] D76199: GlobalISel: Fix round lowering

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 16 07:01:33 PDT 2020


arsenm added a comment.

In D76199#1924416 <https://reviews.llvm.org/D76199#1924416>, @foad wrote:

> Looks OK technically. Why is it useful to lower round and floor in terms of trunc? Is trunc somehow more primitive, or more commonly legal? Does the AMDGPU backend use any of this?


We need the round lowering. I think the floor lowering is now dead in the DAG path (but R600 might need it for f64 if that were ever implemented)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76199/new/

https://reviews.llvm.org/D76199





More information about the llvm-commits mailing list