[PATCH] D76195: [llvm-readobj][test] - Remove unused Offset key from reloc-types-*.test tests

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

In D76195#1923426 <https://reviews.llvm.org/D76195#1923426>, @MaskRay wrote:

> I am kind of concerned that this will make tests on REL targets "more invalid". This is fine with our use of llvm-readobj because the addends aren't used. @jhenderson What do you think?


I'm not sure I understand what you mean by "more invalid". I guess the idea is that the default offset is 0, so REL targets would read their addends from offset 0 rather than whereever they were before. I think this is fine - note that the gABI explicitly allows for multiple relocations to patch the same location.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76195/new/

https://reviews.llvm.org/D76195