[PATCH] D44543: [AsmPrinter] Emit .weak directive for weak linkage on COFF

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo updated this revision to Diff 250521.
mstorsjo edited the summary of this revision.
mstorsjo changed the repository for this revision from rL LLVM to rG LLVM Github Monorepo.
mstorsjo added a comment.
Herald added a subscriber: hiraditya.

Rebased the patch, adjusted the condition to another way of expressing roughly the same, added a comment to the common code.

The current version does emit .weak for both weak_odr, linkonce and linkonce_odr unless they have a comdat associated. Currently, weak/weak_odr/linkonce/linkonce_odr have no effect at all for COFF targets, unless a comdat has been set, so in practice, those cases should be rare (and in most cases not working as intended at the moment anyway).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D44543/new/

https://reviews.llvm.org/D44543

Files:
  llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp
  llvm/test/CodeGen/X86/coff-linkonce.ll
  llvm/test/CodeGen/X86/coff-weak.ll
  llvm/test/CodeGen/X86/dllexport-x86_64.ll
  llvm/test/CodeGen/X86/dllexport.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D44543.250521.patch
Type: text/x-patch
Size: 5495 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200316/8133288c/attachment.bin>