[PATCH] D76164: Fix an assertion error when emitting call site info that combines two DW_OP_stack_values.

Mon Mar 16 03:53:26 PDT 2020

djtodoro added a comment.

Basically, looks good to me, but please post the patch with `-U999999`.

================
Comment at: llvm/test/DebugInfo/MIR/X86/callsite-stack-value.mir:15
+--- |
+  define void @g(float %s.coerce) local_unnamed_addr #0 !dbg !20 {
+  entry:
----------------
since we deleted the attributes, we can delete `#0`

================
Comment at: llvm/test/DebugInfo/MIR/X86/callsite-stack-value.mir:19
+  }
+  declare !dbg !14 void @f(i64, i64) local_unnamed_addr #1
+  !llvm.module.flags = !{!6, !7, !8, !9}
----------------
as well as the `#1`

================
Comment at: llvm/test/DebugInfo/MIR/X86/callsite-stack-value.mir:26
+  !9 = !{i32 7, !"PIC Level", i32 2}
+  !10 = distinct !DICompileUnit(language: DW_LANG_ObjC, file: !15, producer: "clang version 11.0.0 (git at github.com:llvm/llvm-project 32e90cbcd19a83e20a86bfc1cbf7cec9729e9077)", isOptimized: true, runtimeVersion: 2, emissionKind: FullDebug, enums: !12, retainedTypes: !13, nameTableKind: None, sysroot: "/")
+  !12 = !{}
----------------
we can get rid of the ` (git at github.com:llvm/llvm-project 32e90cbcd19a83e20a86bfc1cbf7cec9729e9077)` part

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76164/new/

https://reviews.llvm.org/D76164