[PATCH] D75527: [yaml2obj] - Add `ELFYAML::YAMLInt` to fix how we parse a relocation `Addend` key.

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

Latest updates look good to me, but holding off another LGTM, given the range comments.

I think I can be persuaded that -0x12345678 should not be allowed. I guess very few people would write that, so emitting an error is probably sufficient. I've given it some more thought and I'm okay with rejecting ranges that can't be physically represented in the field too, although I'd allow the maximum/minimum possible values (i.e. INT64_MIN/UINT64_MAX, and possibly 32-bit equivalents). Basically, I'll defer to either of you two on this one. I don't have any strong preferences.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75527/new/

https://reviews.llvm.org/D75527