[PATCH] D76131: [yaml2obj] - Set the default value for `PAddr` property of a program header to a value of `VAddr`

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

Some post-commit comment comments. Otherwise looks fine.



================
Comment at: llvm/test/tools/yaml2obj/ELF/program-header-address.yaml:30
+ProgramHeaders:
+## Show addresses we emit by default for a case when a program header
+## has no sections included.
----------------
Show what virtual and physical address we set by default for the case where a program header

(same below)


================
Comment at: llvm/test/tools/yaml2obj/ELF/program-header-address.yaml:31
+## Show addresses we emit by default for a case when a program header
+## has no sections included.
+  - Type:     PT_LOAD
----------------
has no sections included -> has no sections


================
Comment at: llvm/test/tools/yaml2obj/ELF/program-header-address.yaml:41-42
+      - Section: .foo
+## Now we have a program header that has a virtual address different from
+## a address of the section included. Show that the default physical address
+## is equal to virtual address.
----------------
different from a address -> different to the address


================
Comment at: llvm/test/tools/yaml2obj/ELF/program-header-address.yaml:43
+## a address of the section included. Show that the default physical address
+## is equal to virtual address.
+  - Type:  PT_LOAD
----------------
to the program header's virtual address


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76131/new/

https://reviews.llvm.org/D76131