[PATCH] D76205: Add support for custom op parser/printer hooks to know about result names.

[Chris Lattner via Phabricator via llvm-commits]

lattner added a comment.

Ok, build 53570 looks like it has two unrelated failures, but the parser.mlir failure does look like a problem.  This:

/mnt/disks/ssd0/agent/workspace/amd64_debian_testing_clang8/mlir/test/IR/parser.mlir:1198:16: error: CHECK-NOT: excluded string found in input
 // CHECK-NOT: attributes

  ^

<stdin>:564:36: note: found here
 %x = test.string_attr_pretty_name attributes {name = "x"}

  ^~~~~~~~~~

Failure means that the logic in "print(OpAsmPrinter &p, StringAttrPrettyNameOp op) " is not working.  I don't see how it can fail given that the result name is printing correctly as 'x'.  The logic in question is this:

if (tmpStream.str().drop_front() == op.name())

  elidedAttrs = {"name"};

Does anyone have any ideas?  Needless to say, this works fine on my machine (a mac).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76205/new/

https://reviews.llvm.org/D76205