[PATCH] D76198: [MLIR] fix parse bound error message

Uday Bondhugula via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Mar 15 09:37:40 PDT 2020


bondhugula created this revision.
bondhugula added reviewers: flaub, andydavis1, rriddle.
Herald added subscribers: llvm-commits, Joonsoo, liufengdb, lucyrfox, mgester, arpith-jacob, nicolasvasilache, antiagainst, shauheen, burmako, jpienaar, mehdi_amini.
Herald added a reviewer: nicolasvasilache.
Herald added a project: LLVM.
bondhugula updated this revision to Diff 250428.
bondhugula added a comment.
bondhugula retitled this revision from "[MLIR] fix parse bound error message

- fix parse error message for affine for op's bounds" to "[MLIR] fix parse bound error message".
bondhugula edited the summary of this revision.

fix commit message

Updating D76198: [MLIR] fix parse bound error message
=====================================================

- fix parse error message for affine for op's bounds


- fix parse error message for affine for op's bounds

Signed-off-by: Uday Bondhugula <uday at polymagelabs.com>


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D76198

Files:
  mlir/lib/Dialect/AffineOps/AffineOps.cpp
  mlir/test/IR/invalid.mlir


Index: mlir/test/IR/invalid.mlir
===================================================================
--- mlir/test/IR/invalid.mlir
+++ mlir/test/IR/invalid.mlir
@@ -535,7 +535,7 @@
 
 func @bound_symbol_mismatch(%N : index) {
   affine.for %i = #map1(%N) to 100 {
-  // expected-error at -1 {{symbol operand count and integer set symbol count must match}}
+  // expected-error at -1 {{symbol operand count and affine map symbol count must match}}
   }
   return
 }
@@ -546,7 +546,7 @@
 
 func @bound_dim_mismatch(%N : index) {
   affine.for %i = #map1(%N, %N)[%N] to 100 {
-  // expected-error at -1 {{dim operand count and integer set dim count must match}}
+  // expected-error at -1 {{dim operand count and affine map dim count must match}}
   }
   return
 }
Index: mlir/lib/Dialect/AffineOps/AffineOps.cpp
===================================================================
--- mlir/lib/Dialect/AffineOps/AffineOps.cpp
+++ mlir/lib/Dialect/AffineOps/AffineOps.cpp
@@ -1185,14 +1185,14 @@
     if (map.getNumDims() != numDims)
       return p.emitError(
           p.getNameLoc(),
-          "dim operand count and integer set dim count must match");
+          "dim operand count and affine map dim count must match");
 
     unsigned numDimAndSymbolOperands =
         result.operands.size() - currentNumOperands;
     if (numDims + map.getNumSymbols() != numDimAndSymbolOperands)
       return p.emitError(
           p.getNameLoc(),
-          "symbol operand count and integer set symbol count must match");
+          "symbol operand count and affine map symbol count must match");
 
     // If the map has multiple results, make sure that we parsed the min/max
     // prefix.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D76198.250428.patch
Type: text/x-patch
Size: 1675 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200315/db5de649/attachment.bin>


More information about the llvm-commits mailing list