[PATCH] D75297: [TypeSize] Allow returning scalable size in implicit conversion to uint64_t

[Sander de Smalen via Phabricator via llvm-commits]

sdesmalen added inline comments.


================
Comment at: llvm/CMakeLists.txt:426
+# SVE/SVE2 or other scalable vector architectures.
+option(LLVM_ENABLE_STRICT_IMPLICIT_CONVERSION_TYPESIZE "Enable assertions that type is not scalable in implicit conversion from TypeSize to uint64_t" OFF)
+
----------------
ctetreau wrote:
> sdesmalen wrote:
> > efriedma wrote:
> > > 80 columns
> > The convention in this file doesn't seem to honour 80 chars. I've put the message on a separate line similar to how this is done for other options.
> No need to change it unless you need to upload a patch for some other reason, but I believe the policy is to run clang-format on lines that you touch. The fact that this policy creates local inconsistency is a separate flame war we need not get into here.
> 
> I often get a bot that complains when I mess this up elsewhere in the codebase, but it doesn't seem to run consistently for some reason...
Okay thanks, I wasn't aware that was the official policy. For this specific case though, clang-format doesn't seem to apply to CMake files.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75297/new/

https://reviews.llvm.org/D75297