[PATCH] D76181: [AVR] Add support for the -mdouble=x flag

[Ayke via Phabricator via llvm-commits]

aykevl marked 3 inline comments as done.
aykevl added a comment.

In D76181#1923176 <https://reviews.llvm.org/D76181#1923176>, @MaskRay wrote:

> The GCC side commits can be found on https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92055
>  So it seems that we will have both `-mlong-double-{64,80,128}` (80 is used by x86 fp80) and `-mlong-double={32,64}`... (I actually prefer `=` to `-`)


Yeah I honestly think the `-mlong-double-{64,80,128}` flags are pretty ugly, they should have been `-mlong-double={64,80,128}`. Unfortunately I don't think that can be changed anymore.
I briefly considered using the `-mdouble-{32,64}` format for AVR but apart from it being rather ugly, avr-gcc uses `-mdouble={32,64}` (with `=` instead of `-`). That means there will be two closely related flags in Clang with a different format. I can change it if necessary, although I have a slight preference to match avr-gcc.



================
Comment at: clang/test/CodeGen/mdouble.c:1
+// RUN: %clang_cc1 %s -emit-llvm -o - -triple=avr-unknown-unknown -mdouble=64 | \
+// RUN:   FileCheck --check-prefix=AVR-FP64 %s
----------------
MaskRay wrote:
> Maybe name this file `avr-mdouble.c`
I named this mdouble.c instead of avr-mdouble.c as it seems to me that this flag may be useful for other targets as well and tests can be added to the same file. I can rename this if you think avr-mdouble.c is more appropriate.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76181/new/

https://reviews.llvm.org/D76181