[PATCH] D74677: [bugpoint] Also replace declarations with null.

Sat Mar 14 12:52:27 PDT 2020

fhahn added a comment.

In D74677#1892434 <https://reviews.llvm.org/D74677#1892434>, @reames wrote:

> In D74677#1892136 <https://reviews.llvm.org/D74677#1892136>, @fhahn wrote:
>
> > In D74677#1891680 <https://reviews.llvm.org/D74677#1891680>, @reames wrote:
> >
> > > Calling null is (I think) full out UB.  This may be a more hostile reduction strategy than is warranted.  It's likely to result in extremely unstable reductions.
> > >
> > > An alternative would be to pick a canonical callee (non-null declaration) and map all calls of a given signature to the same decl.
> >
> >
> > My original intention with this patch was to just extend the existing behavior to declarations as well, but I agree using null is not ideal. I'll give your suggestion a try!
>
>
> I possibly didn't read far enough.  Are you saying we will replace the target of a call to a defined function w/null, but not for a call to a declaration?  If so, then yes, simply being consistent is better than nothing.  If that's the case, LGTM.  :)

Yes that's the case at the moment IIUC. This patch should just extend the existing behavior to also include declarations.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74677/new/

https://reviews.llvm.org/D74677