[PATCH] D76174: [ELF] Support linking ET_EXEC

[George Rimar via Phabricator via llvm-commits]

grimar accepted this revision.
grimar added a comment.
This revision is now accepted and ready to land.

I think a one-line patch even for such a rare feature is OK, so LGTM. But lets wait for a second opinion too.



================
Comment at: lld/ELF/Driver.cpp:262
   case file_magic::bitcode:
+  case file_magic::elf_executable:
   case file_magic::elf_relocatable:
----------------
I wonder if we want a comment here.


================
Comment at: lld/test/ELF/executable.test:19
+  .foo : { *(.text) }
+}
----------------
Nit: this could be a single line:

```
# RUN: echo "SECTIONS { .foo : { *(.text) } }" > %t.script
```
This test file could be `*.s`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76174/new/

https://reviews.llvm.org/D76174