[PATCH] D76140: [InlineFunction] update attributes during inlining
Philip Reames via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Mar 13 16:13:07 PDT 2020
reames added a comment.
Anna, I'd encourage you to go very narrow here. We can resolve the correlated throw case with the following: require operand of return to be call instruction which is less than small constant window of non-trapping instructions before the return. (i.e. start with previous node) If we allow bitcasts, that provides reasonable coverage. We can always fallback to assumes as noted.
We don't need to be hugely general analysis wise to be very useful. Calls in tail positions or loads in analogous are very common. We should handle that obvious case.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76140/new/
https://reviews.llvm.org/D76140
More information about the llvm-commits
mailing list