[PATCH] D76157: [SelectionDAGBuilder] Don't set MachinePointerInfo for gather when we find a uniform base

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 13 15:40:40 PDT 2020


craig.topper added a comment.

In D76157#1922467 <https://reviews.llvm.org/D76157#1922467>, @efriedma wrote:

> > I wasn't sure if passing just the "base" pointer was correct.
>
> It doesn't really matter what the MachineMemOperand looks like for an operation that doesn't alias anything. :)


Sorry not the MachineMemOperand, the MemoryLocation we use to call AA->pointsToConstantMemory is using the uniform base ignoring the GEP indices. Is that safe?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76157/new/

https://reviews.llvm.org/D76157





More information about the llvm-commits mailing list