[PATCH] D71027: Support repeated machine outlining

[Jin Lin via Phabricator via llvm-commits]

jinlin added inline comments.


================
Comment at: llvm/test/CodeGen/AArch64/machine-outliner-iterative.mir:1-2
+# RUN: llc -mtriple=aarch64--- -run-pass=prologepilog -run-pass=machine-outliner -machine-outline-runs=2 -verify-machineinstrs %s -o - | FileCheck %s
+# RUN: llc -mtriple=aarch64--- -run-pass=prologepilog -run-pass=machine-outliner -machine-outline-runs=4 -verify-machineinstrs %s -o - | FileCheck %s
+
----------------
paquette wrote:
> I think that it would make sense to use different check prefixes for each level of outlining. That would make it easier to show explicitly what happens when you add extra iterations.
> 
> ```
> # RUN: llc -mtriple=aarch64--- -run-pass=prologepilog -run-pass=machine-outliner -machine-outline-runs=2 -verify-machineinstrs %s -o - | FileCheck %s --check-prefix TWO-RUNS
> 
> # RUN: llc -mtriple=aarch64--- -run-pass=prologepilog -run-pass=machine-outliner -machine-outline-runs=4 -verify-machineinstrs %s -o - | FileCheck %s --check-prefix FOUR-RUNS
> ```
> 
> Also you shouldn't need `--run-pass=prologepilog` here.
> 
Done.


================
Comment at: llvm/test/CodeGen/AArch64/machine-outliner-iterative.mir:113-115
+# CHECK: [[OUTLINED:OUTLINED_FUNCTION_2_[0-9]+]]
+# CHECK-NOT: [[OUTLINED:OUTLINED_FUNCTION_3_[0-9]+]]
+# CHECK-NOT: [[OUTLINED:OUTLINED_FUNCTION_4_[0-9]+]]
----------------
paquette wrote:
> Can you check which instructions are in these functions?
Done.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71027/new/

https://reviews.llvm.org/D71027