[PATCH] D70606: LLD: CET shadow stack support on Windows

[Petr Penzin via Phabricator via llvm-commits]

penzn marked 2 inline comments as done.
penzn added a comment.

I had to edit the comment above, looks like I took snapshot from directory when I was reproducing build instructions, instead of actual test directory. Now the exe and base64 encoding above (in the gist as well) are correct and the test should pass.



================
Comment at: llvm/test/tools/llvm-readobj/COFF/cetcompat.test:4
+# $ cl has_cet.c /link /cetcompat
+RUN: llvm-readobj --coff-debug-directory %p/Inputs/has_cet.exe | FileCheck %s
+
----------------
MaskRay wrote:
> We should avoid a checked-in binary if possible. Can't it be synthesized from a YAML file?
Not at this stage, yaml2obj still needs work to support it. As @ruiu pointed out there is discussion on llvm-dev about making that change.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70606/new/

https://reviews.llvm.org/D70606