[PATCH] D76136: [MLIR] Add support for explicitly signed / unsigned integer constants

[Andi Drebes via Phabricator via llvm-commits]

andidr marked an inline comment as done.
andidr added inline comments.


================
Comment at: mlir/test/IR/parser.mlir:501
 
+  // CHECK: %{{.*}} = constant 42 : ui32
+  %ux = constant 42 : ui32
----------------
stephenneuendorffer wrote:
> My understanding of the design is that i32 is signless, ui32 is unsigned, and si32 is signed...  It seems like you're not testing the explicitly signed case?
Thanks for pointing this out. This is coherent with my understanding. I'll add test cases for signed integers should the decision to support only signless integers in std be revised.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76136/new/

https://reviews.llvm.org/D76136