[PATCH] D76140: [InlineFunction] update nonnnull attribute during inlining

[Philip Reames via Phabricator via llvm-commits]

reames requested changes to this revision.
reames added a comment.
This revision now requires changes to proceed.

This is not correct.  You're modifying the callee function, not the copy of the callee inlined into the caller.  The callee may continue to persist, and may have other callers for which this fact does not apply.  You need to perform this transform on the inlined copy.

See AddAliasScopeMetadata for an example of the approach.

Also, I'd strongly prefer to see this phrased as merging all return attributes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76140/new/

https://reviews.llvm.org/D76140